Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved prompt and release task #1657

Merged
merged 5 commits into from
May 16, 2024
Merged

feat: improved prompt and release task #1657

merged 5 commits into from
May 16, 2024

Conversation

pd93
Copy link
Member

@pd93 pd93 commented May 13, 2024

This PR does a few things - mostly as I found a few issues while creating an improved release task:

  • Added missing additionalProperties: false keys in schema.json
  • Moved prompt check after preconditions and fingerprinting
    • Annoying to be prompted if the task will be stopped anyway
  • Stop prompt from showing if --dry flag is enabled
    • Again, no value to having a prompt if the task won't execute anyway
  • Removed \n from prompt message so that the response is on the same line instead of by itself
    • Just a visual thing really. Looks a bit nicer
  • A significantly improved release tool
    • Uses wildcards (e.g. task release:patch instead of task release -- patch)
    • Lots of docs to help in the --summary and printed after the task completes
    • Prompt and preconditions to make sure it's not run accidentally.

@pd93 pd93 requested a review from andreynering May 13, 2024 14:53
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! 👏 👏 👏

@andreynering andreynering merged commit f35e51e into main May 16, 2024
13 checks passed
@andreynering andreynering deleted the release-task branch May 16, 2024 00:32
andreynering added a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants